feature: add barrier instruction #1118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilsquet
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1118 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 162 162
Lines 10387 10474 +87
Branches 1262 1276 +14
=========================================
+ Hits 10387 10474 +87 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yitchen-tim
reviewed
Sep 4, 2025
src/braket/circuits/text_diagram_builders/ascii_circuit_diagram.py
Outdated
Show resolved
Hide resolved
src/braket/circuits/text_diagram_builders/ascii_circuit_diagram.py
Outdated
Show resolved
Hide resolved
laurencap
reviewed
Sep 4, 2025
| """ | ||
| target_qubits = self.qubits if target is None else QubitSet(target) | ||
|
|
||
| if target_qubits: |
Contributor
There was a problem hiding this comment.
because self.qubits can be None?
Contributor
Author
There was a problem hiding this comment.
The motivation was to not have any effect when adding a barrier to an empty circuit.
…iht the different types of barriers
Contributor
Author
|
Since the linter was not happy anymore with the added complexity introduced here, I had to refactor the |
yitchen-tim
approved these changes
Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#974
Description of changes:
Starting with the changes from #993 and #1002, the
barrierinstruction is implemented as aCompilerDirective. To this end, changes were necessary in a few files.Testing done:
toxMerge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.